Skip to content

next/299/20240214/v1#10419

Merged
victorjulien merged 3 commits intoOISF:masterfrom
victorjulien:next/299/20240214/v1
Feb 14, 2024
Merged

next/299/20240214/v1#10419
victorjulien merged 3 commits intoOISF:masterfrom
victorjulien:next/299/20240214/v1

Conversation

@victorjulien
Copy link
Member

jlucovsky and others added 3 commits February 14, 2024 17:19
This commit improves the mqtt parsing of frames to handle multiple PDUs.

Issue: 6592
Rework locking logic to avoid the following coverity warning.

** CID 1591966:  Concurrent data access violations  (MISSING_LOCK)
/src/detect-engine-loader.c: 475 in DetectLoadersSync()

    474                     SCCtrlMutexLock(loader->tv->ctrl_mutex);
    >>>     CID 1591966:  Concurrent data access violations  (MISSING_LOCK)
    >>>     Accessing "loader->tv" without holding lock "DetectLoaderControl_.m". Elsewhere, "DetectLoaderControl_.tv" is written to with "DetectLoaderControl_.m" held 1 out of 1 times (1 of these accesses strongly imply that it is necessary).
    475                     pthread_cond_broadcast(loader->tv->ctrl_cond);
    476                     SCCtrlMutexUnlock(loader->tv->ctrl_mutex);

The warning itself is harmless.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants